fix(web): keep goal controls beside the composer - #26023

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a small, localized UI bug fix that relocates existing goal controls beside the composer without changing data, APIs, or production infrastructure. An edge case remains where those controls may be hidden while an approval or question drawer is open.

Needs human approval because:

• 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 32ecd71
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 08581d7f-7794-4cc2-a63c-2393eb5ba22e

Commits

Reviewing files that changed from the base of the PR and between d6a967b and 8557fce.

Files selected for processing: 1

• apps/web/src/components/ChatView.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Merge Risk: Minimal · up to 8557f

No actionable merge-blocking risk remains; the goal remains visible and painted beside the composer.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: keeping goal controls beside the composer.
Description check		The description covers the problem, change, linked issue, verification steps, observed results, screenshots, and agent attribution. It does not use the template headings or explicitly state maintainer…
Linked Issues check		Issue #25954 requires goal status and controls to stay accessible while the user reads earlier messages. The whole-PR diff against merge base 32ecd71 changes two files. In `apps/web/src/components/Cha…
Out of Scope Changes check		The whole-PR diff touches only apps/web/src/components/ChatView.tsx and apps/web/src/components/chat/ThreadNow.tsx. Each hunk supports the goal relocation for #25954. The import change and the `ex…

Full details: Description check

Explanation

The description covers the problem, change, linked issue, verification steps, observed results, screenshots, and agent attribution. It does not use the template headings or explicitly state maintainer approval, but it is mostly complete and directly related to the change.

Full details: Linked Issues check

Explanation

Issue #25954 requires goal status and controls to stay accessible while the user reads earlier messages. The whole-PR diff against merge base 32ecd71 changes two files. In apps/web/src/components/ChatView.tsx, goalNow now renders inside the composer surface (ComposerSurface.Main) through the exported ThreadNowLine. The goal no longer appears in the timeline footer: ThreadNow drops its goal prop and render branch, and hasThreadNow no longer counts goalNow. The goal row therefore sits beside the composer and does not depend on scroll position. The issue has no separate automated test requirement. The PR adds no tests, and the issue does not require any. Non-coding verification steps in the PR description are not assessed.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff touches only apps/web/src/components/ChatView.tsx and apps/web/src/components/chat/ThreadNow.tsx. Each hunk supports the goal relocation for #25954. The import change and the export of ThreadNowLine enable the new placement. The ThreadNow prop and render removal eliminate the old footer entry. The hasThreadNow update prevents an empty footer when only a goal exists. No unrelated change is present in the reviewed diff. The PR description's totals (11 additions, 11 deletions) differ slightly from the hunk counts, but this does not affect scope.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

thanks @diddletime. the original correctly identified that goal controls disappear when reading earlier messages. i kept your commit and merged current main into this branch.

the final change reuses the existing goal row beside the composer, outside the question/approval filter and on the common path used by provider-native subagents. this removes the widened banner variant entirely. the row uses the existing composer surface so attached drawers cannot leave its text over the transcript. the final diff against main is two files, 11 additions and 11 deletions.

verification passed on d6a967be737e3665193ec89926833f42e6a84ddd:

• blacksmith vp run check:changed: format, lint, both knip checks, affected typechecks, 42 existing tests and both affected react compiler checks.
• github CI, agent context budget and mobile fingerprint check. preview workflows correctly skipped.
• real codex luna goal in the web client: reproduced main's scrolling problem, paused the goal, scrolled through earlier messages, opened full goal details and used Clear through the provider/client path. Resume and Clear remained reachable at 390px in light and dark themes.
• a persisted question fixture confirms the goal row stays visible and painted while the question is open. this is visual fixture evidence, not a live provider question test.
• two independent source reviews approved the final head. the original drawer/subagent findings and the first review's missing-background finding are addressed.

unverified: packaged electron, native mobile, live provider-native subagents, live approval/question responses and Resume. their command callbacks and provider paths are unchanged.

before on main, scrolled to the beginning of the real goal thread:

after, matching thread, goal and scroll position:

scrolling, details and Clear through codex:

persisted question fixture, cropped to the goal and question controls:

merged current github/main into the existing head without rebasing. resolved the footer condition using main's attention/work fields while keeping the goal beside the composer. head: 8557fce.

blacksmith vp run check:changed passes: format, lint, knip, affected typechecks, 42 focused tests, and compiler coverage. two independent source reviews approve this head. github reports no conflicts. ci is pending.

chrome captures at desktop and narrow web widths use isolated goal fixture state. they verify appearance, not provider-backed resume/clear actions; those actions and pending-request integration remain unverified in this pass.

Verified in a real dev environment

verified as-is at 8557fce687729b525d72e15ba615927fc95e554a on this Linux Boat VM, using repository Playwright and /usr/bin/google-chrome against vp run dev. no mocks, fixtures, seeded conversations, or source changes.

• reproduced on github/main (afb8619e1d) in ../main: created a project pointing at a real git repository through the UI, selected Codex gpt-6.1-sol, generated a long conversation, and set a real goal that asked a question. scrolling to the beginning put the goal row below the viewport (y=1847 in a 1000px viewport).
• stopped main before starting the exact PR head. copied only that isolated app-created dev state for matching captures. the goal remains beside the composer at the same scroll position (y=697), exactly once, with Resume and Clear reachable while the real provider question is open.
• clicked details, Resume, and Clear. Resume started a real Codex goal turn. Clear paused/interrupted goal work, received the provider's thread/goal/cleared event, and removed the row.
• created another real goal/question on the PR. checked 390px web layouts in light and dark themes, opened full details, cleared the goal, and reloaded: the row stayed absent. submitting the question still started a real Codex response. ordinary provider turns and timeline scrolling also worked.
• Blacksmith vp run check:changed passed: format, lint, knip, affected typechecks, 42 focused tests, and React compiler checks. GitHub CI is green. worker setup required fetching git history and installing its Playwright Chromium before the successful run.

short provider transcript from clicking the controls:

16:21:48 outgoing thread/goal/set status=active
16:21:48 incoming turn/started
16:21:48 incoming thread/goal/updated status=active
16:22:00 outgoing thread/goal/set status=paused
16:22:00 outgoing turn/interrupt
16:22:02 outgoing thread/goal/clear
16:22:02 incoming thread/goal/cleared
16:25:00 narrow web Clear -> thread/goal/cleared
reload -> goal row count=0

before, main, same thread and scroll position:

after, exact PR head:

scrolling, full details, Resume starting Codex, and Clear removing the goal (idle gaps shortened; no performance claim):

Not verified

packaged Electron, native iOS/Android, macOS/Windows, relay/tunnel connections, other providers, provider-native subagent views, and live approval drawers. the narrow captures are responsive web, not native mobile. no PR commits or pushes were needed.

main's first checklist response required a page reload to become visible despite a completed provider response. the PR client also needed a reload after its initial cold load of ChatView. both recovered within minutes; neither changed the goal-control result. these startup/live-render observations were not investigated as part of this two-file UI verification.